Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support jackson 2.17 #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pjfanning
Copy link
Contributor

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #xxxx

Purpose

Relates to #1055
There are issues with tests in playframework where some tests deliberately have deeply nested JSON. Jackson now defaults to a limit of 1000.
I would like to support overriding more of the StreamReadConstraints settings in Jackson but this is a start.

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

@pjfanning pjfanning marked this pull request as draft September 5, 2024 00:47
@pjfanning pjfanning force-pushed the jackson-2.17 branch 2 times, most recently from 99b6f8a to 623041a Compare September 5, 2024 01:29
@pjfanning pjfanning marked this pull request as ready for review September 5, 2024 01:36
@pjfanning
Copy link
Contributor Author

@mkurz does this look like a way forward for supporting Jackson 2.15 and above?

One extra change that I would like to make would be to change the visibility of the JacksonJson class to be scoped to [play] as opposed to just the [jackson] package - because 2 playframework tests need to be able to override the nesting depth limit.

more changes

Create PR1072.backwards.excludes

Update JsonConfig.scala

Update JacksonJson.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant